Stop kubernetes log tailer gracefully #1722
Draft
+108
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
force-pushed
the
ptodev/fix-kube-warn-log
branch
from
22f42f2
to
3b08cde
Compare
ptodev
commented
Oct 16, 2024
| // return true, &v1.Pod{}, errors.New("Error creating secret") | ||
| // }) | ||
|
|
||
| // fakeClientset.CoreV1().(*fakecorev1.FakeCoreV1).PrependReactor("logs", "alloy-pod1", func(action k8stesting.Action) (handled bool, ret runtime.Object, err error) { |
There was a problem hiding this comment.
The main problem right now is that I can't get this line to work. I'm not sure how to fake a k8s API which doesn't send any log lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As mentioned in #281, users get this warning with
loki.source.kubernetes:It looks like
reader.ReadString('\n')gets called afterstream.Close()has already been called.Me and @wildum were looking at this today, and we suspect that decoupling the lifetime of the string from the timeout context + moving
stream.Close()to the end oftail()could remove the warning message.The warning message seems to be a cosmetic problem. No logs would be lost, but it's confusing since users don't expect to see a warning for something that works as expected. Making the shutdown more graceful will make the component logs less confusing.
Which issue(s) this PR fixes
Fixes #281
Notes to the Reviewer
I am not yet sure how to test this. When we test it, I'll take the PR out of the draft stage.
PR Checklist